Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples building with pkg-config being present on llvm-mingw #754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix examples building with pkg-config being present on llvm-mingw #754

wants to merge 1 commit into from

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented Jan 6, 2023

By using CMake's official Find Modules and sidestepping pkg-config altogether, we're able to use imported targets without further complexity.

@amyspark
Fix examples building with pkg-config being present on llvm-mingw
7784c8a 
By using CMake's official Find Modules and sidestepping pkg-config
altogether, we're able to use imported targets without further complexity.
farindk added a commit that referenced this pull request Jan 18, 2023
@farindk
simplify CMakeLists.txt further and unset variables after use (#754)
e04bbfe
@farindk
Copy link
Contributor

farindk commented Jan 18, 2023

Thank you. By accident, I did much of the same work as in your patch just yesterday.
Could have saved me a lot of time had I seen this earlier :-)

I added the unset() lines from your patch (see above).
We cannot yet use the JPEG::JPEG syntax, because we still depend on an older cmake version for packaging on ancient Linux versions. Thus, I'll leave your pull request open as a reminder to use this syntax at a later time.

@amyspark
Copy link
Contributor Author

Great to hear @farindk, thanks!

@farindk farindk mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amyspark @farindk